remove catkin_lint suppressions#1343
Conversation
a9350a6 to
a272c95
Compare
|
|
||
| #suppress spurious error: https://github.com/fkie/catkin_lint/issues/62 | ||
| #catkin_lint: ignore_once external_directory missing_directory (${VERSION_FILE_PATH}) | ||
| #catkin_lint: ignore_once external_directory (${VERSION_FILE_PATH}) |
There was a problem hiding this comment.
It looks like you removed the comment explaining and linking to the github issue, but kept the ignore_once - is that what you intended to do?
There was a problem hiding this comment.
(or was that issue only for the missing_directory)?
There was a problem hiding this comment.
Yes, the issue was related to missing_directiory. The external_directoring warning is legitimate but should be suppressed here.
| # replace LIBFCL_LIBRARIES with full path to the library | ||
| find_library(LIBFCL_LIBRARIES_FULL ${LIBFCL_LIBRARIES} ${LIBFCL_LIBRARY_DIRS}) | ||
| set(LIBFCL_LIBRARIES "${LIBFCL_LIBRARIES_FULL}") | ||
| include(FindPkgConfig) |
There was a problem hiding this comment.
This change is a bit different than the rest of this PR - the rest is removing suppresions for caktin_lint; this appears to be updating the way we use pkg_config from cmake. Seems innocuous though, so I'm happy to have it in this PR.
There was a problem hiding this comment.
This is related to this PR, because it successfully suppresses another catkin_lint warning as suggested in fkie/catkin_lint#62 (comment).
There was a problem hiding this comment.
You should keep the original find_package(PkgConfig REQUIRED) though. It's the recommended way of using CMake find modules.
There was a problem hiding this comment.
Thanks for the hint. I thought include(FindPkgConfig) and find_package(PkgConfig REQUIRED) are synonymous.
... after fkie/catkin_lint#62 has been resolved and catkin_lint 1.5.6 has been released.
a272c95 to
dbde093
Compare
fkie/catkin_lint#62 has been resolved and catkin_lint 1.5.6 has been released.
Thus, we can remove some catkin_lint suppressions again.