[kinetic] backport rearrange chomp modules for maintainability #1251#1282
Merged
v4hn merged 8 commits intokinetic-develfrom Jan 11, 2019
Merged
[kinetic] backport rearrange chomp modules for maintainability #1251#1282v4hn merged 8 commits intokinetic-develfrom
v4hn merged 8 commits intokinetic-develfrom
Conversation
8026d48 to
1ebdec0
Compare
jonbinney
reviewed
Dec 28, 2018
|
|
||
| set(VERSION_FILE_PATH "${CATKIN_DEVEL_PREFIX}/include") | ||
| file(MAKE_DIRECTORY "${VERSION_FILE_PATH}") | ||
| #find_package(Boost REQUIRED system filesystem date_time thread iostreams) |
Contributor
There was a problem hiding this comment.
Is it worth adding a note here and in the package.xml about why this is commented out?
- mv collision_distance_field from moveit_experimental to moveit_planners/chomp - mv chomp_optimizer_adapter.cpp into own package in moveit_planners/chomp
... and removed collision_detector_hybrid_plugin_loader
…p/OptimizerAdapter
Currently, there is nothing built in moveit_experimental
... to enforce installing the empty moveit_experimental first
2eff205 to
616ba92
Compare
Contributor
|
@v4hn Is there a special reason that you didn't removed |
Contributor
|
I also added a dependency from moveit_core to moveit_experimental to ensure that the latter (empty one) is installed first. |
rhaschke
approved these changes
Jan 6, 2019
2 tasks
Contributor
Contributor
Author
|
Apparently I just failed to see the header was still there @rhaschke. I will merge this now. -- edit: The additional |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As proposed by @rhaschke in #1251 (comment)
I had to address a few conflicts.
I also included #1256 .