[Windows][melodic] Add ASSIMP_LIBRARY_DIRS for Windows build.#99
Merged
rhaschke merged 2 commits intomoveit:melodic-develfrom Mar 29, 2019
ms-iot:windows_port_fix_assimp
Merged
[Windows][melodic] Add ASSIMP_LIBRARY_DIRS for Windows build.#99rhaschke merged 2 commits intomoveit:melodic-develfrom ms-iot:windows_port_fix_assimp
rhaschke merged 2 commits intomoveit:melodic-develfrom
ms-iot:windows_port_fix_assimp
Conversation
Contributor
Author
|
@rhaschke Hope you can take a look. This is a change I missed to send out earlier. :p |
rhaschke
requested changes
Mar 20, 2019
Contributor
rhaschke
left a comment
There was a problem hiding this comment.
Using link_directories is strongly discouraged. Could you please use cmake to find the absolute path, similarly as here for fcl.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ASSIMP_LIBRARY_DIRS for Windows build.
(Verified in https://aka.ms/ros project.)