Skip to content

chore: update dependencies#77

Merged
konradmichalik merged 3 commits intomainfrom
update-dependencies
Oct 19, 2025
Merged

chore: update dependencies#77
konradmichalik merged 3 commits intomainfrom
update-dependencies

Conversation

@konradmichalik
Copy link
Copy Markdown
Contributor

@konradmichalik konradmichalik commented Oct 19, 2025

Summary by CodeRabbit

  • Tests

    • Simplified test infrastructure by removing explicit reflection accessibility calls across multiple validator test suites.
  • Refactor

    • Updated validator properties and methods to public visibility in the Mismatch Validator component.

  - Upgrading ergebnis/composer-normalize (2.48.0 => 2.48.1)
  - Upgrading friendsofphp/php-cs-fixer (v3.86.0 => v3.87.1)
  - Upgrading phpunit/php-code-coverage (12.3.4 => 12.3.6)
  - Upgrading phpunit/phpunit (12.3.7 => 12.3.8)
  - Upgrading rector/rector (2.1.4 => 2.1.5)
  - Upgrading roave/security-advisories (dev-latest e7589e0 => dev-latest 3602c59)
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Oct 19, 2025

Walkthrough

This pull request systematically removes setAccessible(true) calls from validator test files to simplify reflection-based testing. In one case (MismatchValidator), visibility of internal properties and methods is changed from protected to public to eliminate the need for explicit accessibility overrides.

Changes

Cohort / File(s) Summary
Reflection Accessibility Cleanup
tests/src/Validator/AbstractValidatorTest.php, tests/src/Validator/DuplicateValuesValidatorTest.php, tests/src/Validator/EncodingValidatorTest.php, tests/src/Validator/HtmlTagValidatorTest.php, tests/src/Validator/KeyDepthValidatorTest.php, tests/src/Validator/KeyNamingConventionValidatorTest.php, tests/src/Validator/PlaceholderConsistencyValidatorTest.php
Removed setAccessible(true) calls on ReflectionProperty and ReflectionMethod objects, relying on default reflection behavior for accessing private and protected members during testing.
Public API Expansion
src/Validator/MismatchValidator.php
Changed visibility of keyArray and issues properties from protected to public; changed visibility of resetState() method from protected to public to allow direct access in tests without reflection accessibility overrides.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Multiple test files follow a consistent pattern of removing accessibility overrides, but the visibility changes in MismatchValidator require evaluation for potential impacts on external code and encapsulation design.

Possibly related PRs

Poem

🐰 Barriers tumble, walls fall away,
No more setAccessible—huzzah, hooray!
Public and proud, our properties shine,
Tests run so freely along the fine line.

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Title Check ⚠️ Warning The pull request title "chore: update dependencies" suggests changes to project dependencies (typically version updates in configuration files), but the actual changeset consists entirely of test refactoring and visibility modifier changes in the validator codebase. Specifically, the changes remove setAccessible(true) calls from reflection operations in multiple test files and make some validator properties/methods public instead of protected. This is a fundamental mismatch between what the title claims and what the PR actually contains, making the title misleading and unrelated to the changeset's primary purpose. The title should be revised to accurately reflect the actual changes, such as "refactor: remove setAccessible calls from test reflection usage" or "refactor: adjust validator visibility and simplify test reflection" to better represent the test refactoring and API changes being made rather than suggesting dependency updates.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch update-dependencies

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7e944e7 and 438f36e.

⛔ Files ignored due to path filters (1)
  • composer.lock is excluded by !**/*.lock
📒 Files selected for processing (8)
  • tests/src/Validator/AbstractValidatorTest.php (0 hunks)
  • tests/src/Validator/DuplicateValuesValidatorTest.php (0 hunks)
  • tests/src/Validator/EncodingValidatorTest.php (0 hunks)
  • tests/src/Validator/HtmlTagValidatorTest.php (0 hunks)
  • tests/src/Validator/KeyDepthValidatorTest.php (0 hunks)
  • tests/src/Validator/KeyNamingConventionValidatorTest.php (0 hunks)
  • tests/src/Validator/MismatchValidatorTest.php (0 hunks)
  • tests/src/Validator/PlaceholderConsistencyValidatorTest.php (0 hunks)
💤 Files with no reviewable changes (8)
  • tests/src/Validator/EncodingValidatorTest.php
  • tests/src/Validator/PlaceholderConsistencyValidatorTest.php
  • tests/src/Validator/DuplicateValuesValidatorTest.php
  • tests/src/Validator/KeyNamingConventionValidatorTest.php
  • tests/src/Validator/HtmlTagValidatorTest.php
  • tests/src/Validator/MismatchValidatorTest.php
  • tests/src/Validator/KeyDepthValidatorTest.php
  • tests/src/Validator/AbstractValidatorTest.php

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@konradmichalik konradmichalik merged commit b2fe940 into main Oct 19, 2025
28 checks passed
@konradmichalik konradmichalik deleted the update-dependencies branch October 27, 2025 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant