chore: replace inline CGL steps with reusable GitHub Actions workflow#47
chore: replace inline CGL steps with reusable GitHub Actions workflow#47konradmichalik merged 1 commit intomainfrom
Conversation
WalkthroughThe Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~7 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/cgl.yml(1 hunks)
🔇 Additional comments (1)
.github/workflows/cgl.yml (1)
9-9: Double-check required secrets / inputs are forwardedExternal reusable workflows don’t inherit repository secrets unless you explicitly pass them (e.g.
secrets: inheritor individual mappings). Make sure the called workflow doesn't expect secrets you’re no longer providing; otherwise the job will fail at run-time.
| # Migration | ||
| - name: Run Rector migration | ||
| run: composer migration:rector -- --dry-run | ||
| uses: jackd248/reusable-github-actions/.github/workflows/cgl.yml@main |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Pin the reusable workflow to a commit SHA for supply-chain safety
Referencing main makes the build vulnerable to unintended changes in the external repository. Pin to a specific commit (or a signed tag) instead.
- uses: jackd248/reusable-github-actions/.github/workflows/cgl.yml@main
+ uses: jackd248/reusable-github-actions/.github/workflows/cgl.yml@<commit-sha>This still supports updates—just update the SHA when you intentionally pull in changes.
🤖 Prompt for AI Agents
In .github/workflows/cgl.yml at line 9, the reusable workflow is referenced
using the branch name 'main', which can lead to supply-chain risks due to
unintended changes. Replace 'main' with a specific commit SHA or a signed tag
from the external repository to pin the workflow to a fixed version. This
ensures stability and security while still allowing controlled updates by
changing the SHA when desired.
Summary by CodeRabbit