Reviewing files that changed from the base of the PR and between 7eba781 and 8e9c797.

• phpstan.neon (1 hunks)
• src/Command/ValidateTranslationCommand.php (4 hunks)
• src/Validator/AbstractValidator.php (2 hunks)
• src/Validator/MismatchValidator.php (1 hunks)
• tests/src/Parser/JsonParserTest.php (1 hunks)
• tests/src/Parser/PhpParserTest.php (2 hunks)
• tests/src/Result/ValidationRunTest.php (2 hunks)

phpstan.neon (1)

2-2: LGTM! Raising PHPStan to the highest strictness level.

This change increases static analysis to level 8, which enforces the strictest type checking and null safety rules. The coordinated changes in other files show proper preparation for this stricter analysis.

tests/src/Parser/PhpParserTest.php (2)

230-234: Good defensive programming for null safety.

The null check before assertions ensures the test handles cases where extractKeys() returns null, which is consistent with the stricter PHPStan level 8 requirements.

---

276-282: Consistent null safety pattern applied.

The same defensive null check pattern is properly applied here, maintaining consistency across the test methods.

tests/src/Parser/JsonParserTest.php (1)

268-270: Proper null safety before array operation.

The null check before sort($keys) prevents potential runtime errors if extractKeys() returns null, aligning with PHPStan level 8 requirements.

tests/src/Result/ValidationRunTest.php (2)

266-269: Appropriate null safety for error condition testing.

The null check ensures the test handles cases where statistics might be incomplete due to parser exceptions, which is proper defensive programming for error condition tests.

---

281-284: Consistent error handling pattern.

The same null safety pattern is correctly applied when testing parsers that return null keys, maintaining robust error condition testing.

src/Validator/MismatchValidator.php (1)

40-42: Improved type annotation accuracy.

The refined PHPDoc correctly reflects that inner array values can be string|null, matching the actual implementation where $value ?? null is assigned on line 56. This improves type safety compliance with PHPStan level 8.

src/Validator/AbstractValidator.php (2)

53-58: LGTM! Proper null-safe operator usage for logger debug call.

The null-safe operator prevents potential errors when the logger is not initialized, which is essential for PHPStan level 8 compliance.

---

93-99: LGTM! Consistent null-safe operator usage for logger debug call.

This change maintains consistency with other logger calls in the class and properly handles the nullable logger property.

src/Command/ValidateTranslationCommand.php (5)

41-41: LGTM! Correct import for RuntimeException.

The RuntimeException import is properly added to support the new runtime check.

---

183-183: LGTM! Proper null-safe operator usage for I/O error call.

The null-safe operator prevents potential errors when the I/O interface is not initialized, which is essential for PHPStan level 8 compliance.

---

195-195: LGTM! Consistent null-safe operator usage for I/O warning call.

This change maintains consistency with other I/O calls and properly handles the nullable SymfonyStyle property.

---

209-209: LGTM! Consistent null-safe operator usage for I/O error call.

This change maintains consistency with other I/O calls in the class and properly handles the nullable SymfonyStyle property.

---

214-217: LGTM! Well-implemented runtime check for uninitialized interfaces.

The runtime check ensures both output and input interfaces are properly initialized before creating the Output object. The error message is clear and the exception type is appropriate. This is a good defensive programming practice for PHPStan level 8 compliance.

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch phpstan-8