Reviewing files that changed from the base of the PR and between 0f182c3 and 94e868e.

• README.md (1 hunks)
• src/Command/ValidateTranslationCommand.php (1 hunks)
• src/Validator/EmptyValuesValidator.php (1 hunks)
• src/Validator/ValidatorRegistry.php (1 hunks)
• tests/src/Validator/EmptyValuesValidatorTest.php (1 hunks)
• tests/src/Validator/ValidatorRegistryTest.php (2 hunks)

README.md (1)

83-84: Documentation update looks good.

The new EmptyValuesValidator is properly documented with accurate information about supported formats (XLIFF, Yaml) and warning level. The table formatting is consistent and the validator description clearly explains its purpose.

src/Command/ValidateTranslationCommand.php (1)

107-108: Help text update is consistent and accurate.

The EmptyValuesValidator is properly documented in the command help with a clear, concise description that matches its functionality. The formatting and ordering are consistent with other validators.

src/Validator/ValidatorRegistry.php (1)

18-18: Registry update is correct and consistent.

The EmptyValuesValidator is properly added to the registry in the correct alphabetical position. The class reference follows the same pattern as other validators.

tests/src/Validator/ValidatorRegistryTest.php (3)

8-8: Import statement properly added.

The EmptyValuesValidator import is correctly added to support the test assertions.

---

22-22: Assertion for new validator is correct.

The test properly verifies that EmptyValuesValidator is included in the registry, following the same pattern as other validators.

---

24-24: Count update is accurate.

The expected count is correctly updated from 4 to 5 to reflect the addition of the EmptyValuesValidator.

tests/src/Validator/EmptyValuesValidatorTest.php (1)

1-263: Excellent comprehensive test coverage.

This test file provides thorough coverage of the EmptyValuesValidator with well-structured tests that cover:

• Core functionality: Empty strings, whitespace-only values, null values, and mixed scenarios
• Edge cases: Invalid files, empty keys arrays, and partial emptiness
• Integration: Supported parsers, result types, and message formatting
• Error handling: Proper logging when files are invalid

The tests follow PHPUnit best practices with proper mocking, descriptive method names, and specific assertions. The comprehensive coverage ensures the validator will work correctly across various scenarios.

src/Validator/EmptyValuesValidator.php (6)

1-11: LGTM: Clean file structure and appropriate imports

The file header, namespace declaration, and imports follow PHP standards correctly. All necessary dependencies are imported.

---

12-13: LGTM: Proper class inheritance and interface implementation

The class correctly extends AbstractValidator and implements ValidatorInterface, following the established pattern for validators in this codebase.

---

17-40: LGTM: Robust core validation logic with proper error handling

The processFile() method implementation is well-structured:

• Properly handles the case where extractKeys() returns null by logging an error and returning an empty array
• Correctly identifies empty values using null === $value || '' === trim($value) which catches null values, empty strings, and whitespace-only strings
• Preserves the original value (or converts null to empty string) for later formatting, which enables distinction between empty and whitespace-only values

The logic is sound and handles edge cases appropriately.

---

42-60: LGTM: Appropriate custom formatting for multiple issues

The custom formatIssueMessage() method override is necessary and well-implemented:

• Correctly handles the array structure returned by processFile() where keys are translation keys and values are the empty/whitespace content
• Properly distinguishes between empty and whitespace-only values for clear user feedback
• Uses the appropriate color and level formatting consistent with the result type
• Returns multiple formatted messages joined by newlines, which is appropriate for this validator's output

This override is necessary because the parent class expects a single 'message' key in details, but this validator needs to format multiple key-specific messages.

---

65-68: LGTM: Correct parser support specification

The method correctly specifies support for XliffParser and YamlParser classes, which aligns with the PR objectives to detect empty values in XLIFF and YAML files.

---

70-73: LGTM: Appropriate result type for empty value validation

Using ResultType::WARNING instead of the default ERROR is a thoughtful choice for empty values, as they might be intentional placeholders or work-in-progress translations rather than critical errors.