tests/src/Parser/XliffParserTest.php (1)

458-480: Consider adding edge case test for XLIFF 2.0 with no translation units.

The existing tests cover the happy path well. For completeness, consider adding a test for an XLIFF 2.0 file with an empty <file> element (no <unit> children) to verify that extractKeys() returns an empty array.

Example test case

public function testExtractKeysReturnsEmptyArrayWhenNoUnitsXliff2(): void
{
    $emptyUnitsFile = $this->tempDir.'/empty_units_v2.xlf';
    $emptyUnitsContent = <<<'EOT'
<?xml version="1.0" encoding="utf-8"?>
<xliff xmlns="urn:oasis:names:tc:xliff:document:2.0" version="2.0" srcLang="en">
  <file id="messages">
  </file>
</xliff>
EOT;
    file_put_contents($emptyUnitsFile, $emptyUnitsContent);

    $parser = new XliffParser($emptyUnitsFile);
    $this->assertSame([], $parser->extractKeys());
}

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/src/Parser/XliffParserTest.php` around lines 458 - 480, Add a new unit
test method (e.g., testExtractKeysReturnsEmptyArrayWhenNoUnitsXliff2) that
creates an XLIFF 2.0 file whose <file> element has no <unit> children,
instantiates XliffParser with that file, and asserts that
XliffParser::extractKeys() returns an empty array; ensure the test writes the
file to the same tempDir pattern used in other tests and uses the parser methods
(extractKeys and optionally getLanguage) to validate behavior.

src/Parser/XliffParser.php (1)

59-72: Behavioral change: extractKeys() now returns [] instead of null when units are missing.

Returning an empty array instead of null when translation units are unavailable is a valid approach within the interface contract (array<int, string>|null). However, this is a subtle semantic shift: previously null may have indicated an error condition, while now [] indicates "no keys found."

Based on the relevant code snippets, existing validators handle this correctly:

• MismatchValidator and DuplicateValuesValidator use if (!$keys) which handles both cases.
• PlaceholderConsistencyValidator uses if (null === $keys) which becomes ineffective, but the foreach loop safely handles empty arrays.

No immediate fix needed, but consider documenting this behavior in the interface or aligning the guard in PlaceholderConsistencyValidator for consistency.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Parser/XliffParser.php` around lines 59 - 72, extractKeys() now returns
an empty array instead of null when getTranslationUnits() yields no units;
update the guard in PlaceholderConsistencyValidator (the method that currently
does if (null === $keys)) to treat empty arrays the same as null (e.g., change
the check to if (!$keys) or if (null === $keys || [] === $keys)) so it aligns
with MismatchValidator and DuplicateValuesValidator and preserves the original
semantic for "no keys available"; leave extractKeys() as-is.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes