Ensure path case normalized#130
Merged
davidlatwe merged 1 commit intomottosso:masterfrom Nov 18, 2020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Since Windows's filesystem is case-insensitive,
c:/users/david/packagesandC:/Users/david/packagesboth point to same location, but using direct string compare to find out whether these two path is the same or relatived won't work.And that makes Allzpark fail to identify which package is local (dev) and which is localized, when registered Rez package path and package localize path is not using same letter case.
Fix
Introduce
os.path.normcasesolved the problem.