Minor fixes and adding tests for those fixes#123
Merged
davidlatwe merged 5 commits intomottosso:masterfrom Nov 8, 2020
Merged
Conversation
The default log.level may be NOTSET, which will not equal to DEBUG level. Change condition to less then INFO level fixed the silence.
Collaborator
Author
|
Some previous test failed, but seems not related to current change. Will fix that with another PR. :) |
Change to connect signals before test
Collaborator
Author
|
On second thought, I'd like to try fixing it here, and re-try in another PR if problem still exists. |
Collaborator
Author
|
So in last commit (4e65242), signal waiting in tests should be much stable now. But somehow tests running in Ubuntu still get segmentation fault from time to time, re-run it by GitHub Action may get successful result. Not ideal, but shouldn't be a problem for Allzpark to work in production. Will try improving tests' stability in future PR. Ready to be merged. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
When logging level is
NOTSET(the default), traceback doesn't get printed when exception raised from listing profile. Which I think it should ?bleeding-rezdoesn't have attributeprojectbut__project__. Now therez.projectcan function properly.Tests
A few test cases has been added to reflect the above fixes.