Skip to content

Fix #137#138

Merged
mottosso merged 4 commits intomottosso:masterfrom
abstractfactory:fix137
Sep 16, 2016
Merged

Fix #137#138
mottosso merged 4 commits intomottosso:masterfrom
abstractfactory:fix137

Conversation

@mottosso
Copy link
Owner

Disable run-time testing of attribute overrides.

See original issue #137.

@fredrikaverpil
Copy link
Collaborator

fredrikaverpil commented Sep 16, 2016

Um. I'm not clear on when this issue is triggered. From your example, PySide.QtWidgets must've been created by the user somehow if Qt.py cannot map to it?

@fredrikaverpil
Copy link
Collaborator

fredrikaverpil commented Sep 16, 2016

Since I've never seen this issue I was just curious about when you hit it.

@mottosso
Copy link
Owner Author

I'm not clear on when this issue is triggered.

You and me both.

I never expected to experience it, but it happened and when it did I had no clue about how to find the cause. That feeling is what compelled me to disable it at run-time.

Overall it should be harmless. If anything is overwritten in a vanilla session, it would still be caught by our tests.

@fredrikaverpil
Copy link
Collaborator

Ok, then this looks good to me. :) 👍

@mottosso mottosso merged commit 41102c9 into mottosso:master Sep 16, 2016
@mottosso mottosso deleted the fix137 branch March 24, 2017 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants