Skip to content

Add Suffixes directive#836

Merged
nalchevanidze merged 2 commits intomorpheusgraphql:mainfrom
eunmin:add-suffixes-directive
May 12, 2023
Merged

Add Suffixes directive#836
nalchevanidze merged 2 commits intomorpheusgraphql:mainfrom
eunmin:add-suffixes-directive

Conversation

@eunmin
Copy link
Copy Markdown
Contributor

@eunmin eunmin commented May 12, 2023

Hi~! :)
I'm having a great time with morpheus-graphql. This time I wanted to rename a type, so I tried to use Prefixes, Rename, DropNamespaces, but there was nothing suitable, so I created the Suffixes directive. Please take a look and merge or comment. Thanks.

@nalchevanidze
Copy link
Copy Markdown
Member

@eunmin thanks. looks great.
should we hide it with excludeFromSchema _ = True, since there is no value including it to derived schema?
in that case we can do same for Prefix directive.

instance GQLDirective Suffixes where
  excludeFromSchema _ = True

@nalchevanidze
Copy link
Copy Markdown
Member

and please run npm run format:fix to fix styling issues

@nalchevanidze
Copy link
Copy Markdown
Member

and i realized we don't check if name really contains prefix or suffix. could you please add that too on both?

@todd-kim
Copy link
Copy Markdown

Yes, I'll set the excludeFromSchema value to True to hide both Prefixes and Suffixes from the schema.

@todd-kim
Copy link
Copy Markdown

As you commented, I've done the work and committed it.

@nalchevanidze nalchevanidze merged commit a57dbe7 into morpheusgraphql:main May 12, 2023
ropwareJB pushed a commit to ropwareJB/morpheus-graphql that referenced this pull request Jun 18, 2023
@github-actions github-actions bot mentioned this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants