Support graphql-ws protocol, breaks existing subscriptions-transport-ws protocol#805
Merged
nalchevanidze merged 38 commits intomorpheusgraphql:mainfrom May 11, 2023
Merged
Support graphql-ws protocol, breaks existing subscriptions-transport-ws protocol#805nalchevanidze merged 38 commits intomorpheusgraphql:mainfrom
nalchevanidze merged 38 commits intomorpheusgraphql:mainfrom
Conversation
* publish-release/0.27.0 * cabal Co-authored-by: GitHub <noreply@github.com> Co-authored-by: David Nalchevanidze <d.nalchevanidze@gmail.com>
* deriving on gql type * lifted * GQLType * derive Type * GQLType * catName * clean up * update * format
* deriveGQLType * typeContent * gql type * fillTypeContent * update * insertType * deriveFIelds * inject type * derive KindedType * derive content * mapping * update * derive content * derive field arguments * to Field Content * derive field arguments * update * cant be input type
* clean up Deriving * clean up deriving options ignore undefined GQLType argumentsToObject update update remove utils GLQType * fix subscription * update useDerive schema * useDeriveType * fix schema deriving * GQLType * derive schema * derive * encode value * derive app * update Deriving named * update encodeField * kinded * NamedFun * named * NamedResolvers * resolver * update * build Map * remove decode value * update * remove GQLType from Named Resolver * update * kindedProxy * update * optimize g traversable * scan * GTraversable * scanner * NamedResolvers * flexible context
* kinded * update * update * GMAP * GTRaverse * update * omit visited * fix types * derive named resolvers * update value * scanner refs * fun * resolvers * refs * update * update * useGmap * named resolvers * NamedResolvers * GQLResolver * Grep * GRep * GRep * GRep * GRep * TypeRep * GRep * Rep * typeRep * update * format * GMap * fix Gmap * MonadResolver * class MonadResolver * res * monadResolver * decodeValues * clean up resolvers * resolver * ignoredResolver * update * update * update * monadResolver * resolver * MonadIOResolver * MonadIOResolver * Resolving * MonadIO Resolver * subscribe * MonadResolver * MonadResolver * Update * update * format * found * MonadResolver * runFun
* introspection * MonadResolver * MonadResolver * Typeable * MonadResolver * MonadResolver * lib sub * runResolver * NamedResolvers * Resolver * event * update named * Root * update Resolvers * schema api
This was referenced Dec 21, 2022
Member
|
thanks @ropwareJB. could you please remove Bumping of version to v0.28.0. since i use workflow which handles it automatically based on PR labels on deployment. |
Member
|
morpheus-graphql/config/stack.yaml Lines 4 to 12 in 9ab7ba4 please add |
morpheus-graphql-subscriptions/src/Data/Morpheus/Subscriptions/Apollo.hs
Show resolved
Hide resolved
Member
|
@ropwareJB great work ;) i left some comments there. please run |
Member
|
@ropwareJB by the way if you could also add test cases for new |
…between requests + responses
…est for new protocol
…essage sent to accepted socket
Contributor
Author
|
nalchevanidze
approved these changes
May 11, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will cease support for the older protocol due to line, which changes the name of an event from 'data' to 'next':
https://github.com/morpheusgraphql/morpheus-graphql/pull/805/files#diff-d7568c77ceef4d42fcddd7e99c510f1d7d53592431ab6ff0027f1667b6de68deR160
Deprecation notice:
https://www.npmjs.com/package/graphql-ws#disclaimer
Graphql-ws protocol:
https://github.com/enisdenjo/graphql-ws/blob/master/PROTOCOL.md
Deprecated subscriptions-transport-ws protocol:
https://github.com/apollographql/subscriptions-transport-ws/blob/master/PROTOCOL.md