Fix the return type of more_itertools.batched#993
Merged
bbayles merged 1 commit intomore-itertools:masterfrom May 16, 2025
qobilidop:batched
Merged
Fix the return type of more_itertools.batched#993bbayles merged 1 commit intomore-itertools:masterfrom qobilidop:batched
bbayles merged 1 commit intomore-itertools:masterfrom
qobilidop:batched
Conversation
It should be a tuple of potentially multiple items, rather than a tuple of a single item.
Collaborator
|
For reference, here's the annotation for the standard library's version: https://github.com/python/typeshed/blob/0125fe28489590dd341576147b54dc164e1b016a/stdlib/itertools.pyi#L326 |
bbayles
approved these changes
May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue reference
This is a trivial bug.
Changes
Fixes the return type of
more_itertools.batched. The tuple there should be a tuple of potentially multiple items, rather than a tuple of a single item.Checks and tests
make all-checkspasses.