Skip to content

Remove setup.py file#979

Merged
bbayles merged 1 commit intomore-itertools:masterfrom
cdce8p:remove-setup-py
Apr 30, 2025
Merged

Remove setup.py file#979
bbayles merged 1 commit intomore-itertools:masterfrom
cdce8p:remove-setup-py

Conversation

@cdce8p
Copy link
Copy Markdown
Contributor

@cdce8p cdce8p commented Apr 23, 2025

Changes

The project uses flit_core as build backend. Including the setup.py file should not be necessary anymore.

@bbayles
Copy link
Copy Markdown
Collaborator

bbayles commented Apr 23, 2025

We switched to flit to make it easier for packagers (in particular Gentoo) to build the project. But my understanding at the time (2022) was that other packagers still depended on setup.py, so I left it in. Do you have a sense for how that ecosystem has evolved?

@cdce8p
Copy link
Copy Markdown
Contributor Author

cdce8p commented Apr 23, 2025

As far as I'm aware all major build frontends, mainly pip, poetry, uv, do support independent build systems now. So it should be safe to remove at this point.

Anecdotally, I've removed it on a number of other projects some time ago and so far I haven't seen any complains.

@bbayles bbayles merged commit f22895f into more-itertools:master Apr 30, 2025
6 checks passed
@cdce8p cdce8p deleted the remove-setup-py branch April 30, 2025 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants