Conversation
NeilGirdhar
reviewed
May 20, 2024
more_itertools/more.pyi
Outdated
| def powerset_of_sets(iterable: Iterable[_T]) -> Iterator[set[_T]]: ... | ||
| def join_mappings( | ||
| **field_to_map: dict[Any, dict[Any, Any]] | ||
| ) -> dict[Any, dict[Any, Any]]: ... |
There was a problem hiding this comment.
This annotation seems to have one too many levels of dict on the parameter (your example won't even pass). I would do something like:
def join_mappings(
**field_to_map: Mapping[T, V]
) -> dict[T, dict[str, V]]: ...
Collaborator
Author
There was a problem hiding this comment.
Left over from the earlier implementation - thanks
more_itertools/more.py
Outdated
|
|
||
| >>> user_scores = {'elliot': 50, 'claris': 60} | ||
| >>> user_times = {'elliot': 30, 'claris': 40} | ||
| >>> dict(join_mappings(score=user_scores, time=user_times)) |
There was a problem hiding this comment.
Why make another copy of the return value, which is necessarily a copy already?
Collaborator
Author
There was a problem hiding this comment.
Left over from the earlier implementation - thanks
| yield from starmap(set().union, combinations(sets, r)) | ||
|
|
||
|
|
||
| def join_mappings(**field_to_map): |
There was a problem hiding this comment.
Cool design of joining them by name instead of tuple-index!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re: #839, this PR adds
join_mappings.