Add exactly size of n doc to padded#807
Merged
bbayles merged 4 commits intomore-itertools:masterfrom Feb 7, 2024
Merged
Conversation
Contributor
Author
|
Not sure why this build is failing. Locally there is no issue with |
Contributor
|
I am getting the same "black" reformat warnings from a clean slate + removed erroneous quotes from the workflow file (https://github.com/elliotwutingfeng/more-itertools/actions/runs/7739500311). |
Collaborator
|
Resolution: update to the latest versions of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue reference
#794
Changes
I have used to native method I discussed in the issue to add to the documentation. If this is not acceptable and we want to only compose using the
paddedmethod I don't think any docstring PR should be merged related to this issue.Using the padded method
islice(padded(iterable, '?', n), n)is less performant and less clear than using
islice(chain(iterable, repeat('?')), n)in my opinion.
Thoughts on this are welcome.