Increase performance of padded#805
Merged
bbayles merged 1 commit intomore-itertools:masterfrom Jan 25, 2024
Merged
Conversation
Closed
bbayles
approved these changes
Jan 25, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue reference
#804
Changes
Increases the performance of the
paddedmethod. Main performance gains come from using built in itertools methods and using generators in a more bulk friendly way. See the issue for performance improvement overview.There are a few caveats to this PR and I would like some advice on how to proceed and what would be considered best practice for this project, please see the issue and leave comments.