Merged
Conversation
Some accidentally referred to nth_combination instead
c can never be zero, so the branch is never executed.
Collaborator
|
I took the additional test and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR increases the code coverage to 100% (and ups the required code coverage accordingly), tested on Python 3.8 to 3.12 on Linux. Note this includes a few actual fixes:
NthPermutationTests(some tests accidentally referred tonth_combinationinstead)nth_permutationI chose to simply suppress coverage on a few bits of version-dependent code. As a side note, there is an alternative that I use in my
igbpyutilsproject: Generated.coveragercfiles with tags such as# cover-req-ge3.10and# cover-req-lt3.10for each Python version. This allows me to run Python version-specific coverage checks in that project.