Speed up zip_broadcast() by pre-filling the scalar elements#740
Merged
bbayles merged 2 commits intomore-itertools:masterfrom Jul 28, 2023
Merged
Speed up zip_broadcast() by pre-filling the scalar elements#740bbayles merged 2 commits intomore-itertools:masterfrom
zip_broadcast() by pre-filling the scalar elements#740bbayles merged 2 commits intomore-itertools:masterfrom
Conversation
Closed
bbayles
approved these changes
Jul 28, 2023
lengau
referenced
this pull request
in canonical/charmcraft
Sep 12, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [more-itertools](https://togithub.com/more-itertools/more-itertools) | `==10.0.0` -> `==10.1.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>more-itertools/more-itertools (more-itertools)</summary> ### [`v10.1.0`](https://togithub.com/more-itertools/more-itertools/releases/tag/v10.1.0): Version 10.1.0 [Compare Source](https://togithub.com/more-itertools/more-itertools/compare/v10.0.0...v10.1.0) ##### What's Changed - Add more tests for `zip_broadcast()` by [@​kalekundert](https://togithub.com/kalekundert) in [https://github.com/more-itertools/more-itertools/pull/739](https://togithub.com/more-itertools/more-itertools/pull/739) - Added takewhile_inclusive by [@​OlegAlexander](https://togithub.com/OlegAlexander) in [https://github.com/more-itertools/more-itertools/pull/736](https://togithub.com/more-itertools/more-itertools/pull/736) - Speed up `zip_broadcast()` by pre-filling the scalar elements by [@​kalekundert](https://togithub.com/kalekundert) in [https://github.com/more-itertools/more-itertools/pull/740](https://togithub.com/more-itertools/more-itertools/pull/740) - Added outer_product. by [@​OlegAlexander](https://togithub.com/OlegAlexander) in [https://github.com/more-itertools/more-itertools/pull/743](https://togithub.com/more-itertools/more-itertools/pull/743) - Simplify `zip_broadcast` by [@​pochmann](https://togithub.com/pochmann) in [https://github.com/more-itertools/more-itertools/pull/742](https://togithub.com/more-itertools/more-itertools/pull/742) - Simplify `_zip_equal` by [@​pochmann](https://togithub.com/pochmann) in [https://github.com/more-itertools/more-itertools/pull/744](https://togithub.com/more-itertools/more-itertools/pull/744) - fix consume() type annotation by [@​obaltian](https://togithub.com/obaltian) in [https://github.com/more-itertools/more-itertools/pull/746](https://togithub.com/more-itertools/more-itertools/pull/746) - Version 10.1.0 by [@​bbayles](https://togithub.com/bbayles) in [https://github.com/more-itertools/more-itertools/pull/747](https://togithub.com/more-itertools/more-itertools/pull/747) ##### New Contributors - [@​OlegAlexander](https://togithub.com/OlegAlexander) made their first contribution in [https://github.com/more-itertools/more-itertools/pull/736](https://togithub.com/more-itertools/more-itertools/pull/736) - [@​obaltian](https://togithub.com/obaltian) made their first contribution in [https://github.com/more-itertools/more-itertools/pull/746](https://togithub.com/more-itertools/more-itertools/pull/746) **Full Changelog**: more-itertools/more-itertools@v10.0.1...v10.1.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "every weekend" in timezone Etc/UTC, Automerge - "before 07:00" in timezone Etc/UTC. 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/canonical/charmcraft). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi44My4wIiwidXBkYXRlZEluVmVyIjoiMzYuODMuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#737 got me thinking about how to speed up
zip_broadcast(), and one simple optimization I noticed is that there's no need to initialize thenew_itemlist and fill in all the scalar values on every iteration. That only needs to be done once up front, since the loop will only ever alter the positions innew_itemassociated with the iterable arguments.For the example given in #737, this new version is twice as fast as the old version:
New version:
Old version: