Issue 1003: Multidimensional reshape()#1062
Merged
bbayles merged 15 commits intomore-itertools:masterfrom Aug 21, 2025
Merged
Conversation
pochmann3
reviewed
Aug 19, 2025
Contributor
Author
|
@bbayles I think this is ready to go. Can the 15 commits be squashed together to make a single clean commit in the history? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The core use case is to transform one multidimensional array into another multidimensioal array of the same size but with a different shape. The remaining design decisions pertain to handling size mismatches and non-uniform input:
collapse, subarrays are not required to have equal sizes. This isn't typical but is easily supported.collapse, each dimension is presumed to uniformly consist of all arrays or all scalars.The lazily evaluated transformation stack is constructed by a while-loop and a
reducecall. The only slow part is the value lookahead and theis_scalarcheck which are done only once for each dimension in the input.Once constructed, the transformation stack runs at C speed. It consists of nested calls to
islice,batched, andchain. Here is the transformation stack for converting a 3-d structure to a 4-d structure: