Issue 1005: Document difference from builtin min() and max().#1008
Merged
bbayles merged 1 commit intomore-itertools:masterfrom Jun 18, 2025
Merged
Issue 1005: Document difference from builtin min() and max().#1008bbayles merged 1 commit intomore-itertools:masterfrom
bbayles merged 1 commit intomore-itertools:masterfrom
Conversation
pochmann3
reviewed
Jun 18, 2025
| 2) Comparisons only call `__lt__`, unlike the builtin `max` function | ||
| which calls ``__gt__`` instead. | ||
| 3) Ties are handled differently. The builtin functions always return the | ||
| first minimum or maximum value found in the input. In contrast, |
Contributor
There was a problem hiding this comment.
This function also always returns the first minimum. It's only the max that can be a later one.
(And it can only be the element immediately after the first max and only if they're a considered pair, i.e., the first max is at an odd index. But I wouldn't mention this. Once you don't get the first max like you do from the max() function, it really doesn't matter which later one you get.)
Collaborator
|
Thanks - I made some edits, but appreciate the clarification on |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.