Conversation
cristianpb
left a comment
There was a problem hiding this comment.
I think there are some changes to do to mopidy types
| timePosition, | ||
| }: { | ||
| tl_track: models.TlTrack; | ||
| timePosition: number; |
There was a problem hiding this comment.
| timePosition, | |
| }: { | |
| tl_track: models.TlTrack; | |
| timePosition: number; | |
| time_position, | |
| }: { | |
| tl_track: models.TlTrack; | |
| time_position: number; |
| timePosition, | ||
| }: { | ||
| tl_track: models.TlTrack; | ||
| timePosition: number; |
There was a problem hiding this comment.
| timePosition, | |
| }: { | |
| tl_track: models.TlTrack; | |
| timePosition: number; | |
| time_position, | |
| }: { | |
| tl_track: models.TlTrack; | |
| time_position: number; |
| timePosition, | ||
| }: { | ||
| tl_track: models.TlTrack; | ||
| timePosition: number; | ||
| }) => void; |
There was a problem hiding this comment.
| timePosition, | |
| }: { | |
| tl_track: models.TlTrack; | |
| timePosition: number; | |
| }) => void; | |
| time_position, | |
| }: { | |
| tl_track: models.TlTrack; | |
| time_position: number; | |
| }) => void; |
|
Travis is essentially dead so we've been gradually moving our CI to CircleCI, we'd probably want to do the same here. |
|
Hi there, I would really like to use these types in my project. Why isn't this being merged if I may ask? |
|
@kingosticks wrote:
I've converted this repo from Travis CI to GitHub Actions today. As the build didn't have anything in common with our Python projects and doesn't need the mopidy-ci Docker image to build, I found that GitHub Actions was probably the easiest thing to migrate to. @LorenzKahl wrote:
Sorry, I haven't been very on top of pull requests lately. I've been having some doubts about adding TypeScript definitions, as one of the original design goals for Mopidy.js was to build an API for use from browsers that wouldn't require lots of maintenance, like what e.g. a REST API mapped to Mopidy's Core API would be. Thus, Mopidy.js uses introspection of the Mopidy Core API and is always up to date with the API on the Mopidy server it connects to. When adding TypeScript definitions, we lock Mopidy.js (at least for TypeScript users) to a specific version of the Mopidy Core API. On the other hand, I've grown quite fond of TypeScript and would clearly have used it myself for building a web client, so I want Mopidy.js to support TypeScript. If the Mopidy Core API grows/changes, Mopidy.js users will have to help out updating the TypeScript definitions or use some I'll soon push a PR that integrates all the work from @altano, @whomwah, and @cristianpb. |
Hi @jodal
Typescript is getting very popular, so I think this can be very useful for everyone and should fix #27
I took the types definition from #27 and add them to mopidy.js repository.
I also added a simple github CI workflow. It's nice to have all CI integrated in github, but if let you chose if you want this or travis.