[corefx] Compile System.Native and ship it as a shared library#4824
Closed
luhenry wants to merge 3 commits intomono:masterfrom
Closed
[corefx] Compile System.Native and ship it as a shared library#4824luhenry wants to merge 3 commits intomono:masterfrom
luhenry wants to merge 3 commits intomono:masterfrom
Conversation
5926e34 to
89a30d5
Compare
3447c5b to
0349d8c
Compare
alexischr
reviewed
May 25, 2017
mono/pal/Makefile.am
Outdated
|
|
||
| clean-local: | ||
| -rm -rf System.Native$(libsuffix) | ||
| -rm -rf $(COREFX_ROOT)/bin/$(COREFX_PAL_OS).$(COREFX_PAL_ARCH).Release |
Contributor
There was a problem hiding this comment.
$(COREFX_ROOT)/bin/obj/$(COREFX_PAL_OS).$(COREFX_PAL_ARCH).Release also needs to be rm'd here
|
@luhenry I hope that merge of this PR will be made, because System.Native is necessary dependecy of my PR in bounds of GSoC 2017 👍 |
vargaz
approved these changes
Sep 14, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.