Mono: use shared StartHelper object#20740
Merged
akoeplinger merged 1 commit intomono:masterfrom Jan 13, 2021
Merged
Conversation
Revert dotnet/runtime#46390 which reverted the Mono parts of dotnet/runtime#46244. Fixes dotnet/runtime#46389 The issue was that the code in dotnet/runtime#46244 throws in `Thread` constructors before calling `Initialize`. Which will then cause a finalizer to run on a partially-initialized thread object, which means that `ves_icall_System_Threading_InternalThread_Thread_free_internal` will be called with a null `MonoInternalThread:longlived` field.
lambdageek
approved these changes
Jan 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
!! This PR is a copy of dotnet/runtime#46896, please do not edit or review it in this repo !!
Do not automatically approve this PR:
* Consider how the changes affect configurations in this repo,
* Check effects on files that are not mirrored,
* Identify test cases that may be needed in this repo.
!! Merge the PR only after the original PR is merged !!
Revert dotnet/runtime#46390 which reverted the Mono parts of dotnet/runtime#46244.
Fixes dotnet/runtime#46389
The issue was that the code in dotnet/runtime#46244 throws in
Threadconstructors before callingInitialize. Which will then cause a finalizer to run on a partially-initialized thread object, which means thatves_icall_System_Threading_InternalThread_Thread_free_internalwill be called with a nullMonoInternalThread:longlivedfield.