[sgen] Add Ward annotations to sgen_get_total_allocated_bytes#20517
Merged
lambdageek merged 2 commits intomono:masterfrom Nov 6, 2020
Merged
[sgen] Add Ward annotations to sgen_get_total_allocated_bytes#20517lambdageek merged 2 commits intomono:masterfrom
lambdageek merged 2 commits intomono:masterfrom
Conversation
Member
Author
|
cc @akoeplinger |
57005cd to
331afff
Compare
Contributor
|
What does MONO_PERMIT actually do? |
Member
Author
naricc
reviewed
Oct 27, 2020
| void sgen_update_allocation_count (void) | ||
| MONO_PERMIT (need (sten_world_stopped)); | ||
| guint64 sgen_get_total_allocated_bytes (MonoBoolean precise) | ||
| MONO_PERMIT (need (sgen_lock_gc, sgen_stop_world)); |
Contributor
There was a problem hiding this comment.
So, I'm not sure if this matters, but sgen_get_total_allcoated_bytes only needs that lock if precise is true. I guess that is ok as a static over approximation though?
Member
Author
There was a problem hiding this comment.
yea Ward is not at all flow sensitive, so that kind of conditional information is lost on it.
akoeplinger
reviewed
Oct 28, 2020
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
Member
Author
|
@monojenkins build failed |
akoeplinger
approved these changes
Nov 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to fix https://jenkins.mono-project.com/job/test-mono-mainline-staticanalysis/