[2020-02][corlib] ThreadAbortException protection for ArraySortHelper#20468
Merged
lambdageek merged 3 commits intomono:2020-02from Oct 9, 2020
Merged
Conversation
The custom comparer is wrapped in a try/finally. Verify that it doesn't turn thread abort exceptions into some other exception. Regression test for mono#15418
To pick up fix for mono#15418
cd4621e to
a0c5c28
Compare
steveisok
approved these changes
Oct 8, 2020
0ae8a0f to
c983c52
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump
external/corertThe ArraySortHelper catches all exceptions in the comparer.
If the sorting thread is aborted while it is running the comparer, the
ArraySortHelper will catch the TAE and propagate an InvalidOperationException
instead.
As a workaround, catch and rethrow TAEs separately.
Add regression test
Related to #15418
Backport of #20467