[wasm] Fix the propagation of exceptions through runtime invokes.#20117
Merged
vargaz merged 1 commit intomono:masterfrom Jul 15, 2020
Merged
[wasm] Fix the propagation of exceptions through runtime invokes.#20117vargaz merged 1 commit intomono:masterfrom
vargaz merged 1 commit intomono:masterfrom
Conversation
The previous code would convert exceptions into errors which would be rethrown later, clearing the resume state. Hopefully fixes dotnet/runtime#38337.
BrzVlad
approved these changes
Jul 14, 2020
Contributor
Author
|
@monojenkins build failed |
Member
|
@monojenkins build Windows x64 FullAOT |
Contributor
Author
|
@monojenkins build failed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous code would convert exceptions into errors which would
be rethrown later, clearing the resume state.
Hopefully fixes dotnet/runtime#38337.