Skip to content

Conversation

@BrzVlad
Copy link
Member

@BrzVlad BrzVlad commented Jun 29, 2020

No description provided.

BrzVlad added 4 commits June 30, 2020 11:13
This also compacts stack usage. A new frame starts at the location of the first pushed argument.
We replace them with opcodes that operate on locals instead. This also enables additional optimizations that were applying to locals.
It is now redundant
By mistake, the filter frame was using the same stack space as the original frame. This means that the filter clause could corrupt frames from which we still need to run finally clauses. This also refactors the code a little bit, moving frame copying outside interp_exec_method, which is already overly complex.
@BrzVlad BrzVlad force-pushed the feature-interp-local-args branch from ef51bc4 to f711e5b Compare June 30, 2020 08:15
@vargaz
Copy link
Contributor

vargaz commented Jul 7, 2020

Looks nice.

@vargaz
Copy link
Contributor

vargaz commented Jul 7, 2020

The wasm failures are unrelated.

@BrzVlad BrzVlad merged commit 6de06a3 into mono:master Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants