WIP: Port EventPipeBuffer, EventPipeBufferList, EventPipeBufferManager to Mono.#19958
Merged
lateralusX merged 1 commit intomono:masterfrom Jun 30, 2020
Merged
Conversation
862becd to
bedda84
Compare
bedda84 to
a614d03
Compare
a614d03 to
e2d111f
Compare
lateralusX
approved these changes
Jun 29, 2020
lambdageek
approved these changes
Jun 29, 2020
e2d111f to
3443cf5
Compare
…Mono. Continuation of dotnet/runtime#34600, adding BufferManager into the library including unit tests, merging source files and additional library restructuring. - Port EventPipeBuffer. - Port EventPipeBufferList. - Port EventPipeManager. - Merge internals source files. Changed GETTER_SETTER to only mandate use of inlined functions when calling betweeen source files for different types. Upgraded all use within each source file for direct struct access. - Changed function entry error checkin strategy. Only apply active checks on outer library API, ep.h, and use EP_ASSERT for all other functions. - Dropped requires_lock_held in function naming, switch to comment in header or in forward declare for functions that validates that lock is held. - Removed currently unused GETTER/SETTERS. - Moved more comments into sources from corresponding CoreCLR EventPipe sources. - Add EventPipeBuffer/EventPipeBufferManager unit tests. Next step after this PR will be to enable a file session during runtime and add more unit tests and then start getting diagnostic server component over to Mono.
3443cf5 to
68e9066
Compare
Member
|
WASM debugger failure is known and happens on all PR's. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
!! This PR is a copy of dotnet/runtime#37756, please do not edit or review it in this repo !!
Do not automatically approve this PR:
* Consider how the changes affect configurations in this repo,
* Check effects on files that are not mirrored,
* Identify test cases that may be needed in this repo.
!! Merge the PR only after the original PR is merged !!
Continuation of dotnet/runtime#34600, adding BufferManager into the library including unit tests, merging source files and additional library restructuring.
Next step after this PR will be to enable a file session during runtime and add more unit tests and then start getting diagnostic server component over to Mono.