[wasm] Throw PlatformNotSupportedException instead of NotSupportedException when starting threads/waiting on monitors.#19937
Merged
vargaz merged 2 commits intomono:masterfrom Jun 8, 2020
Merged
Conversation
…eption when starting threads/waiting on monitors.
lambdageek
reviewed
Jun 8, 2020
Contributor
Author
|
Will preserve the netcore version later when that infrastructure is set up. |
Member
Does this file not get used: https://github.com/dotnet/runtime/blob/master/src/mono/netcore/System.Private.CoreLib/src/LinkerDescriptor/System.Private.CoreLib.xml |
lambdageek
approved these changes
Jun 8, 2020
Contributor
Author
|
Yes, but there are all kinds of reorgs happening wrt that code. |
Contributor
Author
|
@monojenkins build failed |
1 similar comment
Contributor
Author
|
@monojenkins build failed |
Member
|
@vargaz adding this to the netcore linker xml should be fine now, not sure which reorgs you mean that would affect this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.