[jit] Return the compiled method and an unbox trampoline from ldvirtftn when calling ldvirtftn on a valuetype method.#19809
Merged
vargaz merged 7 commits intomono:masterfrom May 23, 2020
Merged
Conversation
…tn when calling ldvirtftn on a valuetype method. Fixes dotnet/runtime#34379.
Contributor
|
Two coreclr tests related to this issue need to be enabled as well. |
…ter unwind info for trampolines.
Also handle unbox trampolines during the addr->method lookup. * Merge mono_delegate_ctor () and mono_delegate_ctor_with_method (). * Move the actual logic to mini_init_delegate (). * Remove callbacks.create_jump_trampoline, its not used any more.
8ffd067 to
4159355
Compare
Contributor
Author
|
@monojenkins build failed |
Contributor
Author
|
This seems to work now. |
Contributor
Author
|
To recap, the problem with the previous patch was that mono_delegate_ctor () would need to do an address->method reverse lookup, and it couldn't do it because address was pointing to an unbox trampoline, which was not registered in the JIT info tables. |
BrzVlad
reviewed
May 21, 2020
Contributor
|
You need to somehow port this to dotnet\runtime and update the issues.target file to run these changes and tests enabled and make sure those pass. |
Contributor
Author
|
@monojenkins build failed |
BrzVlad
reviewed
May 22, 2020
BrzVlad
approved these changes
May 22, 2020
Contributor
Author
|
@monojenkins build failed |
Contributor
Author
|
@monojenkins build |
Contributor
Author
|
@monojenkins build failed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/runtime#34379.