[Mono] Intrinsify Interlocked.And and Interlocked.Or using LLVM#19135
Merged
EgorBo merged 1 commit intomono:masterfrom Mar 10, 2020
Merged
[Mono] Intrinsify Interlocked.And and Interlocked.Or using LLVM#19135EgorBo merged 1 commit intomono:masterfrom
EgorBo merged 1 commit intomono:masterfrom
Conversation
These APIs were introduced recently in dotnet/runtime#33042 and already used in several places e.g. in `Task`, `InterlockedBitVector32`, `SafeHandle`, `RegexCharClass` It should emit `%reg = atomicrmw and (or)` in LLVM IR. (and unlike `Interlocked.Add` these API return old value, see dotnet/runtime#33102 Addresses dotnet/runtime#32239 for Mono.
974ae2f to
d8132fa
Compare
vargaz
approved these changes
Mar 5, 2020
Member
|
@monojenkins build failed |
Member
|
@monojenkins build Linux AArch64 Coop Suspend |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
!! This PR is a copy of dotnet/runtime#33253, please do not edit or review it in this repo !!
Do not automatically approve this PR:
* Consider how the changes affect configurations in this repo,
* Check effects on files that are not mirrored,
* Identify test cases that may be needed in this repo.
!! Merge the PR only after the original PR is merged !!
These APIs were introduced recently in dotnet/runtime#33042 and already used in several places e.g. in
Task,InterlockedBitVector32,SafeHandle,RegexCharClassIt should emit
%reg = atomicrmw and (or)in LLVM IR. (and unlikeInterlocked.Addthese API return old value, see dotnet/runtime#33102Addresses dotnet/runtime#32239 for Mono.