Skip to content

[2019-12] Bump msbuild to track mono-2019-10#18131

Merged
radical merged 3 commits intomono:2019-12from
radical:bump_msbuild_2019-12
Dec 13, 2019
Merged

[2019-12] Bump msbuild to track mono-2019-10#18131
radical merged 3 commits intomono:2019-12from
radical:bump_msbuild_2019-12

Conversation

@radical
Copy link
Member

@radical radical commented Dec 11, 2019

  • msbuild doesn't have a separate branch for mono-2019-12 right now

@radical
Bump msbuild to track mono-2019-10
58806bf 
- msbuild doesn't have a separate branch for mono-2019-12 right now
@akoeplinger akoeplinger changed the title Bump msbuild to track mono-2019-10 [2019-12] Bump msbuild to track mono-2019-10 Dec 11, 2019
@akoeplinger akoeplinger added this to the 2019-12 (6.10.xx) milestone Dec 11, 2019
@radical radical mentioned this pull request Dec 11, 2019
Merged
@kg
Copy link
Member

kg commented Dec 11, 2019

What are the .pybk and .lock files for? Can we explain it in the commit message?

@radical radical force-pushed the bump_msbuild_2019-12 branch from 83bded0 to 5e1293e Compare December 11, 2019 21:09
@radical
Copy link
Member Author

radical commented Dec 11, 2019

@kg oops, committed that by mistake! the "SAVEPOINT" commits were from switching branches!

@radical
Copy link
Member Author

radical commented Dec 12, 2019

Linux AArch64 FullAOT+LLVM:

MonoTests.test-sgen-regular-ms-conc-simple.sgen-new-threads-dont-join-stw.exe

@radical
Copy link
Member Author

radical commented Dec 12, 2019

@monojenkins build failed

@radical radical removed the request for review from alexischr December 12, 2019 11:56
@radical
Copy link
Member Author

radical commented Dec 12, 2019

Linux x64 C++:
helix tests failing or getting interrupted?

06:57:30 Unhandled Exception:
06:57:30 System.Threading.Tasks.TaskCanceledException: A task was canceled.

...

make: *** [wait-for-job-completion] Error 1
06:57:30 Makefile:18: recipe for target 'wait-for-job-completion' failed
06:57:30 make: Leaving directory '/mnt/jenkins/workspace/test-mono-pull-request-amd64-cxx/mcs/tools/mono-helix-client'
06:57:30 /mnt/jenkins/workspace/test-mono-pull-request-amd64-cxx/scripts/ci/babysitter: Test suite terminated with code 2, and suite cannot report test case data. Halting.
06:57:30 *** end(922): wait-helix-tests: Unstable

@radical
Copy link
Member Author

radical commented Dec 12, 2019

@akoeplinger thoughts about #18131 (comment) ?

@radical
Copy link
Member Author

radical commented Dec 13, 2019

@monojenkins build failed

@radical radical merged commit ac8a9a9 into mono:2019-12 Dec 13, 2019
@radical radical deleted the bump_msbuild_2019-12 branch December 13, 2019 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akoeplinger akoeplinger akoeplinger approved these changes

+2 more reviewers

@lewing lewing lewing approved these changes

@kg kg kg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2019-12 (6.10.xx)

Development

Successfully merging this pull request may close these issues.

4 participants

@radical @kg @lewing @akoeplinger