Mirror changes from mono/corefx,coreclr#17775
Closed
Dotnet-GitSync-Bot wants to merge 4 commits intomono:masterfrom
Closed
Mirror changes from mono/corefx,coreclr#17775Dotnet-GitSync-Bot wants to merge 4 commits intomono:masterfrom
Dotnet-GitSync-Bot wants to merge 4 commits intomono:masterfrom
Conversation
* Rewrite the rest of the array non-generic fast paths in C# * Add missing resource string * Use CorElementType and handle native ints to match the unmanaged implementation * Avoid try pattern for Sort and Reverse * Match the native implementation more closely Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
* Rewrite Enum.CompareTo in C# * Handle floating point too for match the existing native implementation Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
* Remove unused argument from GetRegionDisplayName * Address race conditions in CultureData While most of the race conditions in this file are benign, in these cases, a thread could end up returning an intermediate value due to multiple potential writes to the same field. Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
…) (#27716) Will enable the rule in corefx once these changes have propagated. Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Contributor
|
Resolved by #17777, can be closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains mirrored changes from mono/corefx,coreclr
Please REBASE this PR when merging
cc @jkotas @stephentoub