Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dotnet/linker
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: e21bb44
Choose a base ref
...
head repository: dotnet/linker
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 5d376b1
Choose a head ref
  • 4 commits
  • 16 files changed
  • 2 contributors

Commits on Aug 10, 2021

  1. Fix warnings for DAM.All (#2191)

    * Fix warnings for DAM.All
    
    Fixes #2159
    
    * Add tests
    
    * PR feedback
    
    - Remove unnecessary helper
    
    * Avoid redundant DAM warnings for base members
    
    * PR feedback
    
    - Resolve -> TryResolve
    - Avoid nested yield returns
    - Testcases with base instantiated over self for generic parameter with
      requirements
    sbomer authored Aug 10, 2021
    Configuration menu
    Copy the full SHA
    d8b94bd View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2021

  1. Configuration menu
    Copy the full SHA
    7bf5cd4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    272bd6d View commit details
    Browse the repository at this point in the history
  3. Fix suppression check with assembly suppressions (#2180)

    * Fix suppression check with assembly suppressions
    
    The change in #2171 was incorrect
    because it didn't account for the possibility that the suppressions
    cache already contains assembly or module suppressions for the provider.
    
    This fixes the check by re-using the cache to also track whether we have
    scanned for suppression attributes on the provider. This caching is
    necessary since we warn about duplicate suppressions.
    
    Providers without any suppressions may still be scanned multiple times
    since we don't cache the negative result.
    
    * Populate cache eagerly to avoid extra state
    
    Now whenever we add a record to the cache, we ensure that all of the
    suppressions that might apply to the member have been discovered.
    This way we don't need to track whether we have scanned the suppressed
    member, but have to do a bit more work up-front.
    
    * Use private accessibility
    
    For methods only used in
    UnconditionalSuppressMessageAttributeState
    sbomer authored Aug 11, 2021
    Configuration menu
    Copy the full SHA
    5d376b1 View commit details
    Browse the repository at this point in the history
Loading