Modifies the RequestUri property on HttpRequestMessage to validate the same way as the constructor does. (#361)

steveisok · web-flow · commit 8e3b279377d1 · 2019-10-14T09:37:02.000-04:00
It will now call into IsAllowedAbsoluteUri, which adds some mono specific checks.
diff --git a/src/System.Net.Http/src/System/Net/Http/HttpRequestMessage.cs b/src/System.Net.Http/src/System/Net/Http/HttpRequestMessage.cs
@@ -81,15 +81,23 @@ public HttpMethod Method
             }
         }
 
+
         public Uri RequestUri
         {
             get { return _requestUri; }
             set
             {
+#if MONO
+                if ((value != null) && (!IsAllowedAbsoluteUri(value)))
+                {
+                    throw new ArgumentException(SR.net_http_client_http_baseaddress_required, nameof(value));
+                }
+#else
                 if ((value != null) && (value.IsAbsoluteUri) && (!HttpUtilities.IsHttpUri(value)))
                 {
                     throw new ArgumentException(SR.net_http_client_http_baseaddress_required, nameof(value));
                 }
+#endif
                 CheckDisposed();
 
                 // It's OK to set 'null'. HttpClient will add the 'BaseAddress'. If there is no 'BaseAddress'

Original file line number	Diff line number	Diff line change
`@@ -81,15 +81,23 @@ public HttpMethod Method`
`81`	`81`	`}`
`82`	`82`	`}`
`83`	`83`
	`84`	`+`
`84`	`85`	`public Uri RequestUri`
`85`	`86`	`{`
`86`	`87`	`get { return _requestUri; }`
`87`	`88`	`set`
`88`	`89`	`{`
	`90`	`+#if MONO`
	`91`	`+ if ((value != null) && (!IsAllowedAbsoluteUri(value)))`
	`92`	`+ {`
	`93`	`+ throw new ArgumentException(SR.net_http_client_http_baseaddress_required, nameof(value));`
	`94`	`+ }`
	`95`	`+#else`
`89`	`96`	`if ((value != null) && (value.IsAbsoluteUri) && (!HttpUtilities.IsHttpUri(value)))`
`90`	`97`	`{`
`91`	`98`	`throw new ArgumentException(SR.net_http_client_http_baseaddress_required, nameof(value));`
`92`	`99`	`}`
	`100`	`+#endif`
`93`	`101`	`CheckDisposed();`
`94`	`102`
`95`	`103`	`// It's OK to set 'null'. HttpClient will add the 'BaseAddress'. If there is no 'BaseAddress'`