Fix invalid enum base types being generated in C# source#1899
Merged
Fix invalid enum base types being generated in C# source#1899
Conversation
Collaborator
|
This should probably be done as a pass, so it works across all backends. I don't think we have an appropriate pass at the moment, so either a new one, or maybe re-use |
Collaborator
|
And can you add a test please? |
Contributor
Author
|
Sure can do ! :) |
a3af59f to
3ade6b5
Compare
tritao
reviewed
Feb 4, 2025
3ade6b5 to
31ff92c
Compare
Contributor
Author
|
@tritao Can you run the failed job again? Yesterday evening there was something wrong with the ssl server causing the download to fail occasionally |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To give an example of this going wrong. C++ allows
boolas an enum base type.