Skip to content

Conversation

@jsdidierlaurent
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Dec 24, 2019

Codecov Report

Merging #126 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #126      +/-   ##
==========================================
+ Coverage   97.67%   97.68%   +<.01%     
==========================================
  Files          55       55              
  Lines        1680     1683       +3     
==========================================
+ Hits         1641     1644       +3     
  Misses         39       39
Flag Coverage Δ
#core 97.68% <100%> (ø) ⬆️
Impacted Files Coverage Δ
monitorable/pingdom/repository/api.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45e312e...0f744e8. Read the comment docs.

Copy link
Member

@Alex-D Alex-D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove/ignore binaries folder

@jsdidierlaurent jsdidierlaurent force-pushed the fix/missing-tags-parameters branch from 10e9483 to 0f744e8 Compare December 30, 2019 10:13
@jsdidierlaurent jsdidierlaurent merged commit 7cc5808 into master Dec 30, 2019
@jsdidierlaurent jsdidierlaurent deleted the fix/missing-tags-parameters branch December 30, 2019 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants