Skip to content

refactor(back): merge all tile types #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jsdidierlaurent merged 6 commits into from
Oct 3, 2019
Merged

refactor(back): merge all tile types #106

jsdidierlaurent merged 6 commits into from
Oct 3, 2019

Conversation

@jsdidierlaurent
Copy link
Member

@jsdidierlaurent jsdidierlaurent commented Oct 2, 2019

  • Tile don't contains Category anymore
  • Tile Message is used to expose Text only
  • Tile Values is used to expose metrics
  • Tile Unit explain "values" and gives hints on how to display it

@codecov
Copy link

codecov bot commented Oct 2, 2019 •
edited
Loading

Codecov Report

Merging #106 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #106      +/-   ##
==========================================
+ Coverage    97.2%   97.21%   +0.01%     
==========================================
  Files          47       48       +1     
  Lines        1393     1402       +9     
==========================================
+ Hits         1354     1363       +9     
  Misses         39       39
Flag Coverage Δ
#back 97.21% <100%> (+0.01%) ⬆️
Impacted Files Coverage Δ
monitorable/config/models/config.go 100% <ø> (ø) ⬆️
models/error.go 100% <ø> (ø) ⬆️
monitorable/ping/usecase/ping.go 100% <100%> (ø) ⬆️
monitorable/port/usecase/port.go 100% <100%> (ø) ⬆️
pkg/monitoror/cache/build.go 100% <100%> (ø) ⬆️
monitorable/config/usecase/usecase.go 100% <100%> (ø) ⬆️
monitorable/config/usecase/hydrate.go 100% <100%> (ø) ⬆️
monitorable/http/usecase/http.go 100% <100%> (ø) ⬆️
monitorable/jenkins/usecase/jenkins.go 100% <100%> (ø) ⬆️
models/tile.go 100% <100%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c15766e...2cb302f. Read the comment docs.

@jsdidierlaurent jsdidierlaurent force-pushed the refactor/merge-tile-types branch from a1b8de2 to c9b7efb Compare October 3, 2019 09:47
jsdidierlaurent and others added 5 commits October 3, 2019 12:41
@jsdidierlaurent @Alex-D
refactor(back): merge all tile types
0824233 
- Merge BuildTile, HealthTile and CounterTile in Tile
- Remove TileCategory
- Add Values and Unit for numeric result
- HttpTile return Values or Message in case of content type

BREAKING CHANGES:

- Tile don't contains Category anymore
- Tile Message is used to expose Text only
- Tile Values is used to expose metrics
- Tile Unit explain "values" and gives hints on how to display it
@Alex-D
fix(back/faker): add Unit and Values to ping faker
e997fd7
@Alex-D
refactor(back): rename tile value to values
7254f1f
@Alex-D
feat(front): show last value instead of message
f52b2cf
@jsdidierlaurent @Alex-D
refactor(back): add missing t to formatting in http usecase
7b64b2a
@Alex-D Alex-D force-pushed the refactor/merge-tile-types branch from d2bf1ef to 7b64b2a Compare October 3, 2019 11:19
@jsdidierlaurent jsdidierlaurent merged commit 0965df4 into master Oct 3, 2019
@jsdidierlaurent jsdidierlaurent deleted the refactor/merge-tile-types branch October 3, 2019 13:47
@jsdidierlaurent
Copy link
Member Author

jsdidierlaurent commented Oct 3, 2019

fix: #84

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Alex-D Alex-D

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jsdidierlaurent @Alex-D