feat(NODE-5272): do not create or drop ecc collections#3678
Merged
Conversation
nbbeeken
requested changes
May 23, 2023
a13a103 to
2c719b1
Compare
nbbeeken
approved these changes
May 24, 2023
5 tasks
Contributor
|
@baileympearson Is "fix" correct here? asking because the original PR was a feat |
Contributor
Author
|
I think so - why was the original PR a feat? @nbbeeken
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
The driver no longer creates an ecc collection when creating an encrypted collection.
Additionally, the QE v2 protocol requires 7.0+ servers. This means that driver 4.x would be incompatible with QE unless we bump the max wire version for 4.x to 21.
Backport of #3660
Is there new documentation needed for these changes?
What is the motivation for this change?
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript