Skip to content

Fix data race in 'discard connections' pool test.#1860

Merged
matthewdale merged 1 commit into
mongodb:masterfrom
matthewdale:fix-discard-connections-race
Oct 14, 2024
Merged

Fix data race in 'discard connections' pool test.#1860
matthewdale merged 1 commit into
mongodb:masterfrom
matthewdale:fix-discard-connections-race

Conversation

@matthewdale

@matthewdale matthewdale commented Oct 11, 2024

Copy link
Copy Markdown
Contributor

Summary

  • Don't share the err variable in the goroutine closure (pool_test.go line 893) to prevent a data race.
  • Enable the race detector in the test-short Taskfile target.

Background & Motivation

The race detector panics because of a data race in the "discards connections closed by the server side" connection pool test:

WARNING: DATA RACE
Read at 0x00c0005f4aa0 by goroutine 4142:
  go.mongodb.org/mongo-driver/v2/x/mongo/driver/topology.TestPool_checkOut.func10.3()
      /Users/matt.dale/work/mongo-go-driver/x/mongo/driver/topology/pool_test.go:897 +0x1b0

Previous write at 0x00c0005f4aa0 by goroutine 3796:
  go.mongodb.org/mongo-driver/v2/x/mongo/driver/topology.TestPool_checkOut.func10()
      /Users/matt.dale/work/mongo-go-driver/x/mongo/driver/topology/pool_test.go:907 +0x90c
...

@mongodb-drivers-pr-bot mongodb-drivers-pr-bot Bot added the review-priority-low Low Priority PR for Review: within 3 business days label Oct 11, 2024
@mongodb-drivers-pr-bot

mongodb-drivers-pr-bot Bot commented Oct 11, 2024

Copy link
Copy Markdown
Contributor

API Change Report

No changes found!

This was referenced Oct 11, 2024
Merged
Merged
@matthewdale matthewdale merged commit a056cbc into mongodb:master Oct 14, 2024
@matthewdale matthewdale mentioned this pull request Oct 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qingyang-hu qingyang-hu qingyang-hu approved these changes

Assignees

No one assigned

Labels

review-priority-low Low Priority PR for Review: within 3 business days

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@matthewdale @qingyang-hu