SERVER-62498: non-const unique_function should not convert to std::function e…#1437
Closed
CaseyCarter wants to merge 1 commit intomongodb:masterfrom
Closed
SERVER-62498: non-const unique_function should not convert to std::function e…#1437CaseyCarter wants to merge 1 commit intomongodb:masterfrom
const unique_function should not convert to std::function e…#1437CaseyCarter wants to merge 1 commit intomongodb:masterfrom
Conversation
…ven after LWG-2774 [LWG-2774](https://wg21.link/lwg2774) changes `std::function`'s converting constructor to accept its argument by forwarding reference. With that change implemented, that constructor becomes a better match for non-`const` `unique_function` arguments than `unique_function`'s `const`-qualified deleted conversion operator template to `std::function`. As a result, `std::is_convertible_v<unique_function<T>, std::function<T>>` changes from `false` to `true` when Standard Libraries implement LWG-2774. (MSVC recently implemented this LWG issue in microsoft/STL#2098 and noticed the `unique_function` test failing as a result.) I believe the fix is to add another deleted conversion operator template that is not `const`-qualified to `unique_function`. This makes the test pass locally, as well as correcting a simplified test case with GCC trunk (microsoft/STL#2098) which I believe also implements LWG-2774.
|
Hi @CaseyCarter,
Thanks! |
Contributor
Author
Done!
Also done: https://jira.mongodb.org/browse/SERVER-62498. Do I need to link the ticket and PR somehow? I did add a link to the ticket pointing here. |
const unique_function should not convert to std::function e…const unique_function should not convert to std::function e…
BillyDonahue
approved these changes
Jan 11, 2022
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ven after LWG-2774
LWG-2774 changes
std::function's converting constructor to accept its argument by forwarding reference. With that change implemented, that constructor becomes a better match for non-constunique_functionarguments thanunique_function'sconst-qualified deleted conversion operator template tostd::function. As a result,std::is_convertible_v<unique_function<T>, std::function<T>>changes fromfalsetotruewhen Standard Libraries implement LWG-2774. (MSVC recently implemented this LWG issue in microsoft/STL#2098 and noticed theunique_functiontest failing as a result.)I believe the fix is to add another deleted conversion operator template that is not
const-qualified tounique_function. This makes the test pass for me locally with the updated STL.