RUBY-3557 Mark SecureRandom as Global#341
Merged
comandeo-mongo merged 1 commit intomongodb:masterfrom Nov 15, 2024
Merged
Conversation
SecureRandom needs to be marked global so that it does not possibly get moved during GC compaction.
comandeo-mongo
approved these changes
Nov 15, 2024
Contributor
comandeo-mongo
left a comment
There was a problem hiding this comment.
@zacheryph This is fantastic, thank you very much for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SecureRandom needs to be marked global so that it cannot be moved during GC compaction. When this happens the
pvt_SecureRandommay reference a different object, or nothing at all causing a segfault.I am not quite sure how a test would be written for this since it'd have to be run on its own, and it segfaults the process so the suite wouldn't run. This can be reproduced (on master), and shown resolved (on this branch) with the following: