TEST: explicitly require stringio#340
Merged
comandeo-mongo merged 1 commit intomongodb:masterfrom Dec 10, 2024
Merged
Conversation
Since spec/spec_helper.rb uses StringIO class, make this file explicitly require stringio.
Contributor
Author
|
Testing with
Executing bson-ruby head With ~/.spec restored, the following error does not happen, perhaps because loading rspec format style somewhere loads stringio internally in rspec. But anyway I think explicitly adding stringio dependency inside bson-ruby is desirable. |
comandeo-mongo
approved these changes
Dec 10, 2024
Contributor
|
@mtasaka Thank you very much for your contribution! |
This was referenced Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since spec/spec_helper.rb uses StringIO class,
make this file explicitly require stringio.