You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thank you for taking the time to do this translation!
I'm going to reject this PR, because the purpose of spanish.json5 is to provide a minimal demonstration of how to translate your plugin to other languages. For testing and demonstration purposes, this plugin pack only needs two langName.json5 files: english.json5 and one other (in this case, Spanish). Adding a third would increase the number of files in the plugin for no real benefit. All the "end users" of this plugin pack are C# programmers who will use it as a starting point to create their own plugins, and those end users will need to understand English anyway, because that's the language the source code is written in.
If, for example, you wanted to add a turkish.json5 file to translate JsonTools into Turkish, I might accept your PR (assuming I was satisfied with the quality of the translations), because that is a real plugin with users who don't want to read the source code and might benefit from having the plugin's UI translated into another language.
If you are interested in doing translations like this, I would recommend not translating the comments, and only translating the values. That makes it easier for a plugin author to use a diff viewer to see what you changed. For example:
{// don't translate this here"don't translate keys": "YOU CAN TRANSLATE THIS"}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.