Skip to content

Create turkish.json5#8

Closed
mahirgul wants to merge 1 commit intomolsonkiko:mainfrom
mahirgul:patch-1
Closed

Create turkish.json5#8
mahirgul wants to merge 1 commit intomolsonkiko:mainfrom
mahirgul:patch-1

Conversation

@mahirgul
Copy link

No description provided.

@molsonkiko
Copy link
Owner

@mahirgul

Thank you for taking the time to do this translation!

I'm going to reject this PR, because the purpose of spanish.json5 is to provide a minimal demonstration of how to translate your plugin to other languages. For testing and demonstration purposes, this plugin pack only needs two langName.json5 files: english.json5 and one other (in this case, Spanish). Adding a third would increase the number of files in the plugin for no real benefit. All the "end users" of this plugin pack are C# programmers who will use it as a starting point to create their own plugins, and those end users will need to understand English anyway, because that's the language the source code is written in.

If, for example, you wanted to add a turkish.json5 file to translate JsonTools into Turkish, I might accept your PR (assuming I was satisfied with the quality of the translations), because that is a real plugin with users who don't want to read the source code and might benefit from having the plugin's UI translated into another language.

If you are interested in doing translations like this, I would recommend not translating the comments, and only translating the values. That makes it easier for a plugin author to use a diff viewer to see what you changed. For example:

{
// don't translate this here
     "don't translate keys": "YOU CAN TRANSLATE THIS"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants