[PowerBI] private link add Microsoft/privateLinkServicesForPowerBI#2
Merged
[PowerBI] private link add Microsoft/privateLinkServicesForPowerBI#2
Conversation
Add private link support for powerbi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Register Microsoft.PowerBI/privateLinkServicesForPowerBI provider to support private link for PowerBI
Testing Guide
Add test cases following this guideline
Add 1 class PowerBINetworkARMTemplateBasedScenarioTest(ScenarioTest) with 2 functions:
test_private_endpoint_connection_powerbi: test all the 7 required test cases in guideline, marked as skipped because our test account has a "Subscription is not registered" error, which blocks "az network private-endpoint-connection reject". Since we don't have other usable test account and need to onboard this provider in CLI, I leave this test function skipped. Also we have verified that our service supports reject on backend.
test_private_endpoint_connection_powerbi_ignoreReject: test all the required test cases except reject.
History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.