Fix memory layout of ScNotificationHeader#146
Merged
mohzy83 merged 1 commit intomohzy83:masterfrom Jan 18, 2026
Merged
Conversation
* adds the `CharacterSource` field introduced in Scintilla v4.2.0 [^1], part of the Notepad++ API since v7.8 [^2] * corrects field alignment for x64 assemblies [^3] [^1]: https://sourceforge.net/p/scintilla/code/ci/4cfac35c71bd9612663a8761aec745bd6bb74e1f [^2]: notepad-plus-plus/notepad-plus-plus@92bad0a [^3]: kbilsted/NotepadPlusPlusPluginPack.Net#101
Owner
|
Thanks @rdipardo ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed
struct(whereSci_Positionis a pointer-width integer): https://www.scintilla.org/ScintillaDoc.html#SCNotificationNot (yet) fixed
Character positions remain limited to 32-bit values; i.e., notifications will not work properly in files of >2 GiB: https://community.notepad-plus-plus.org/post/73553
The strictly correct type of
ScNotificationHeader.IdFromis UIntPtr(to match thewParamfield); but this will create a cascade of type errors in dependent modulesThe field name
Mmodifiers(sic) remains misspelled; fixing it may break dependent modules