chore(deps): update sdk dep#488
Merged
gioboa merged 3 commits intomodule-federation:mainfrom Mar 17, 2026
Merged
Conversation
commit: |
gioboa
reviewed
Mar 16, 2026
Collaborator
gioboa
left a comment
There was a problem hiding this comment.
there is an error in the mfe/runtime code
[PARSE_ERROR] Error: Cannot use import statement outside a module
╭─[ node_modules/.pnpm/@module-federation+runtime-core@2.2.1/node_modules/@module-federation/runtime-core/dist/utils/load.cjs:1:1 ]
│
1 │ const require_logger = require('./logger.cjs');
gioboa
approved these changes
Mar 17, 2026
Collaborator
gioboa
left a comment
There was a problem hiding this comment.
Looks great to me 👏 thanks @joshuaellis you rock!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
the
sdkdependency now correctly tree-shakes node-esque code when atargetis correctly set.Related issues