feat(modern-js): enbale asyncStartup by default#4531
Conversation
- Add @rspack/core canary version to package.json overrides - Allow any @rspack/* peer dependencies - Fix indentation in config type definitions - Enable asyncStartup for rspack bundler when not explicitly disabled - Remove redundant enableAsyncEntry condition in source config
…rtup # Conflicts: # package.json # pnpm-lock.yaml
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@module-federation/devtools
@module-federation/cli
create-module-federation
@module-federation/data-prefetch
@module-federation/dts-plugin
@module-federation/enhanced
@module-federation/error-codes
@module-federation/esbuild
@module-federation/managers
@module-federation/manifest
@module-federation/metro
@module-federation/metro-plugin-rnc-cli
@module-federation/metro-plugin-rnef
@module-federation/modern-js
@module-federation/modern-js-v3
@module-federation/native-federation-tests
@module-federation/native-federation-typescript
@module-federation/nextjs-mf
@module-federation/node
@module-federation/retry-plugin
@module-federation/rsbuild-plugin
@module-federation/rspack
@module-federation/rspress-plugin
@module-federation/runtime
@module-federation/runtime-core
@module-federation/runtime-tools
@module-federation/sdk
@module-federation/storybook-addon
@module-federation/third-party-dts-extractor
@module-federation/treeshake-frontend
@module-federation/treeshake-server
@module-federation/typescript
@module-federation/utilities
@module-federation/webpack-bundler-runtime
@module-federation/bridge-react
@module-federation/bridge-react-webpack-plugin
@module-federation/bridge-shared
@module-federation/bridge-vue3
@module-federation/inject-external-runtime-core-plugin
commit: |
Bundle Size Report16 package(s) changed, 24 unchanged. Package dist + ESM entry
Bundle targets
Consumer scenarios
Total dist (raw): 6.30 MB (-4543340 B (-40.8%)) Bundle sizes are generated with rslib (Rspack). Package-root metrics preserve the historical report. Tracked subpath exports such as |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cdf288c158
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| modernjsConfig.source?.enableAsyncEntry !== true && | ||
| targetMFConfig.experiments?.asyncStartup !== false |
There was a problem hiding this comment.
Base asyncStartup default on resolved async-entry setting
The new guard ties experiments.asyncStartup to the raw modernjsConfig.source?.enableAsyncEntry value, but this plugin later defaults enableAsyncEntry to true for Rspack in api.config. As a result, two effectively equivalent configs behave differently: leaving enableAsyncEntry unset turns asyncStartup on, while explicitly setting enableAsyncEntry: true turns it off. That means projects already pinning enableAsyncEntry: true will silently miss the new default async startup path.
Useful? React with 👍 / 👎.
🦋 Changeset detectedLatest commit: a7d2ced The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Description
enbale asyncStartup by default
Related Issue
Types of changes
Checklist